Strange code in net.http.server

bgaifullin · May 9, 2017, 4:35pm

I cannot understand this code in file net.http.server

golang/go/blob/master/src/net/http/server.go#L1826


		} else {
			if w.conn.bufr.Buffered() > 0 {
				w.conn.r.closeNotifyFromPipelinedRequest()
			}
			w.conn.r.startBackgroundRead()
		}


		// HTTP cannot have multiple simultaneous active requests.[*]
		// Until the server replies to this request, it can't read another,
		// so we might as well run the handler in this goroutine.
		// [*] Not strictly true: HTTP pipelining. We could let them all process
		// in parallel even if their responses need to be serialized.
		// But we're not going to implement HTTP pipelining because it
		// was never deployed in the wild and the answer is HTTP/2.
		serverHandler{c.server}.ServeHTTP(w, w.req)
		w.cancelCtx()
		if c.hijacked() {
			return
		}
		w.finishRequest()
		if !w.shouldReuseConnection() {

Seems like
c.rwc.SetReadDeadline(time.Now().Add(d)) (line 1821) has no effect,
because line 1826 runs always.

Can anyone clarify what really happens?

bgaifullin · May 9, 2017, 4:40pm

Sorry, I get out it, the timeout is for the next read on line 1822.

system · August 7, 2017, 4:40pm

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.