Hello,
I am new to go and web technologies. I am writing my own tools for better understanding and learning. Here is my server-monitor for Linux. Please check and comment. All comments welcome, i am learning a lot from your feedbacks.
Best regards…
1 Like
Hi!
- don’t use
-in package name -> https://golang.org/doc/effective_go.html#package-names - I think that you don’t need almost all packages at all. For example, https://github.com/ermanimer/server-monitor/tree/master/recorder contains only one file
- I think you don’t have graceful shutdown implemented -> https://developer20.com/golang-tips-and-trics-iii/
- personally, I’d change the file
database/models.gotodatabase/record.go - in lines like this https://github.com/ermanimer/server-monitor/blob/master/database/database.go#L45 you’re lacking more information about the error. I know you log it but IMO it’s better to return the error
fmt.Errorf("inserting record failed: %w", err)and log it higher
Thank you for your guiding review!